Bingo for meetings–hide results–part 8

Bingo is a small project, written in TypeScript , and developed with Alexandru Badita in launch break (one hour - more or less). You can find sources at . Those are my blog posts for Bingo : ( scroll below for the post)

1Create meeting
2Create Tests
3Finalize Create meeting
4Sharing meeting
5Keep Score
6Add obsolete
7Finalizing obsolete
8End meeting
9Dockerize tests
10Azure CI tests
11Yarn workspaces
13Intermezzo - CLI improvements
14typescript compile run with node
15NestJS ,swagger and create a meeting
16Finalizing API
17Intermezzo - jest vs jasmine error
18Refactor WebAPI and test service
19Heroku Deploy NestJs
21Deploy Angular to GitHub

(Now the actual blog post for Bingo Meetings project)

The last requirement says

The score of how many cards/ what cards were checked will be available 1 hour and 5 minutes


We have already done something similar when the meeting was considered obsolete – we decided to not throw error, but use

Result< T, Error> . So I supposed to be easy …. However, it was not. Because we are modifying the results of the functions, we are supposed to modify also the tests….

First , then modification of the code. Because of the refactoring, the AllUnchecked function calls   TotalNumberOfCardsChecked.


public TotalNumberOfCardsChecked():number{
        return this.Cards.filter(it=>it.IsChecked()).length ;
    public AllUnchecked(): boolean{
        return (this.TotalNumberOfCardsChecked() === 0);


Now, because we cannot TotalNumberOfCardsChecked returns  Result<number, Error> , the function  AllUnchecked must be re-written :


     public TotalNumberOfCardsChecked():Result<number, Error>{
            return ok(this.Cards.filter(it=>it.IsChecked()).length );
            //TODO :Make a proper error
            return err(new Error(`cannot see score for ${this.Id}`));
    public AllUnchecked(): Result< boolean, Error>{
        var res=this.TotalNumberOfCardsChecked();
        console.log(" all unchecked" + res.isOk());
        return res.andThen(it=> ok(it===0));
        // const ret= res.match(
        //     (v)=>{return ok(v==0)},
        //     (error)=>{ return error}
        // );
        // return ret;


Second , the test will fail. Take “card should be checked” – original code was pretty easy


import  MeetingsFactory from '../MeetingsFactory';
import Meeting from '../meeting';
describe('Check  card basic', () => {
    it('card should be checked', () => {
        const mf=new MeetingsFactory();
        const m1=mf.CreateMeeting("andrei","first meeting");
        m1.CheckCard(m1.Cards[0], m1.Participants[0]);    
        expect(m1.IsCardCheckedByParticipant(m1.Cards[0], m1.Participants[0])).toBe(true);


Now it is


it('card should be checked', () => {
        const mf=new MeetingsFactory();
        const m1=mf.CreateMeeting("andrei","first meeting");
        let res=m1.AllUnchecked();
        let result= false;> result =t);
        let res1 = m1.CheckCardByParticipant(m1.Cards[0], m1.Participants[0]);
        result= false;> result =t);
        expect(m1.IsCardCheckedByParticipant(m1.Cards[0], m1.Participants[0]).isOk()).toBe(true);