Comments for A Programmer with Microsoft tools

Comment on Some code by Siderite

Siderite — Tue, 15 May 2012 05:32:22 +0000

We have this practice at the office where we code review all new code. So I have experience with stuff like that (also known as colleague bashing – it should be a national sport! )

Comment on Some code by Andrei Ignat

Andrei Ignat — Sun, 13 May 2012 19:55:18 +0000

For me it was main 3 things:
– use of error code and of the exception
– invalid name of the function
– magic constants codes

Thank you for your answers!

Comment on Some code by Matt

Matt — Sun, 13 May 2012 17:58:36 +0000

- inproper naming conventions
- number error codes
- checking to see if a doc is null after new? wth.
- invalid use of catch block. (if your not going to do anything with it, let it bubble up)

Comment on Ask for help by Andrei Ignat

Andrei Ignat — Sat, 12 May 2012 10:59:03 +0000

Same as for SqlServer

Comment on Ask for help by yudha alkhair

yudha alkhair — Fri, 11 May 2012 17:28:49 +0000

hello sir..
can you help me?

how to create tree menu C# runtime from database mysql?
i view your tutorials in this link
http://www.youtube.com/watch?v=D7T8xRo16IM

thank you

Comment on Some code by Siderite

Siderite — Tue, 08 May 2012 06:51:25 +0000

- ridiculous name for the document class
- the declaration of the doc object should be moved into the try block, it is only used there
- doc can never be null in C# after new
- a numeric code error (use an Enum)

other issues that may be design flaws or design features:
- procedural style of coding: static method that uses out parameters to present state
- using File.Exists to check for the existence of the file, thus assuming knowledge of the internal workings of MyNewDocument
- same thing for empty path, the responsibility of getting a document should rest with the class

Comment on Some code by Ovi

Ovi — Mon, 07 May 2012 11:32:37 +0000

1. FileDocPath should be respect the lower camel case notation.
2. It is not advisable to throw exceptions as part of the logical method flow.

Comment on Some code by Tudor

Tudor — Mon, 07 May 2012 06:19:11 +0000

Destule:
- returnarea de erorr codes prin parametri out in loc de exceptii
- naming conventions in C# (FileDocPath pascal case in loc de camel case)
- inghite toate exceptiile in loc sa le prinda doar pe cele specifice
- arunca o exceptie nespecifica (throw new Exception())
- functie statica publica (greu de facut unit testing cu asa ceva)
- initializarea doc cu null inainte de a apela constructorul (initializare inutila)
- un constructor in C# nu va crea niciodata un obiect null (eventual va arunca o exceptie), deci acel if (doc == null) e inutil

Comment on Jquery Ajax Request and MVC detailed by Dmitriy

Dmitriy — Mon, 07 May 2012 05:58:53 +0000

good article about jquery and ajax. Thanks)))

Comment on Azure tools by Andrei Ignat

Andrei Ignat — Tue, 24 Apr 2012 10:48:27 +0000

Do you have another good wordpress theme?
Thank you,
Andrei